Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't fail
  • Loading branch information
jrbourbeau committed Sep 27, 2024
commit 60769d308c88fcd785d68f86895fff24a53cb3ba
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
if: (! contains(matrix.python-version, 'pypy'))
run: |
coverage xml
coverage report --show-missing --fail-under=100
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line here as it requires every single CI build to have 100% coverage. This isn't quite right in cases when there are Python version-specific lines of code (which we have in toolz).

Instead, let's merge coverage reports across all CI build with codecov to make sure that, summed across all Python versions, we have 100% coverage.

# coverage report --show-missing --fail-under=100
- name: codecov
if: (! contains(matrix.python-version, 'pypy'))
uses: codecov/codecov-action@v3
Expand Down