Remove DataParallel container in SS-VAE model #3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of the
DataParallelcontainer, because it seems to cause issues.The issues only come with cuda enabled, because otherwise the
DataParallelis not used. When runningpython ss_vae_M2.py --cudamemory is allocated on more than one GPU, but nothing seems to happen.However, after dropping the
--cuda, i.e. runningpython ss_vae_M2.py, everything works fine. Code also works withCUDA_VISIBLE_DEVICE=1 python ss_vae_M2.py --cuda, hence the multi-gpu training create the trouble.On the other hand, it is recommended to use DistributedDataParallel, see here.
I think the lines can be dropped, since MNIST is not a dataset where multi-GPU training is needed anymore ;).
I installed pyro from the latest dev branch (v1.8.5) and pytorch v2.0.1.
PR also contains minor housekeeping.