Skip to content

Conversation

ordabayevy
Copy link
Member

Closes #3196

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

"In Pyro, all of this logic is taken care of automatically by the `SVI` class. In particular as long as we use a `TraceGraph_ELBO` loss, Pyro will keep track of the dependency structure within the execution traces of the model and guide and construct a surrogate objective that has all the unnecessary terms removed:\n",
"\n",
"```python\n",
"svi = SVI(model, guide, optimizer, TraceGraph_ELBO())\n",
Copy link
Collaborator

@martinjankowiak martinjankowiak Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "A equals B" or "A is equal to B" but not "A equals to B"

Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fehiepsi fehiepsi merged commit dd4e0f8 into dev Apr 20, 2023
@ordabayevy ordabayevy deleted the provenance-tutorial branch April 20, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upate "Dependency tracking in Pyro" section in SVI tutorial

3 participants