Skip to content

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Dec 12, 2022

Resolves #3162

@martinjankowiak martinjankowiak merged commit 77a67ff into dev Dec 12, 2022
@martinjankowiak martinjankowiak deleted the allow-torch-2 branch December 12, 2022 20:49
Balandat added a commit to Balandat/botorch that referenced this pull request Jan 3, 2023
This includes two major changes of interest to botorch:
1. Support for pytorch 2.0 (allowing us to not require pyro dev branch when testing against pytorch nightlies): pyro-ppl/pyro#3164
2. The ability to registering of custom exception handlers for numerical issues: pyro-ppl/pyro#3168
Balandat added a commit to Balandat/botorch that referenced this pull request Jan 4, 2023
Summary:
This includes two major changes of interest to botorch:
1. Support for pytorch 2.0 (allowing us to not require pyro dev branch when testing against pytorch nightlies): pyro-ppl/pyro#3164
2. The ability to registering of custom exception handlers for numerical issues: pyro-ppl/pyro#3168

Pull Request resolved: meta-pytorch#1606

Reviewed By: saitcakmak

Differential Revision: D42330914

Pulled By: Balandat

fbshipit-source-id: 440d9ff00df60f4ba88acc82e323f9e675caf254
facebook-github-bot pushed a commit to meta-pytorch/botorch that referenced this pull request Jan 4, 2023
Summary:
This includes two major changes of interest to botorch:
1. Support for pytorch 2.0 (allowing us to not require pyro dev branch when testing against pytorch nightlies): pyro-ppl/pyro#3164
2. The ability to registering of custom exception handlers for numerical issues: pyro-ppl/pyro#3168

Pull Request resolved: #1606

Reviewed By: saitcakmak

Differential Revision: D42330914

Pulled By: Balandat

fbshipit-source-id: 1117e7713b99819b4f1297de2d49aeb1bd2b9c9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyTorch 2.0 compatibility: Explicit PyTorch 1.x check causing issues with packages that depend on PyTorch / pyro (e.g. BoTorch)

2 participants