Skip to content

Fix infer.csis to ignore gradient when parameter not used, which has a gradient of None #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix infer.csis to ignore gradient when parameter not used, which has a gradient of None #2828

merged 1 commit into from
Apr 28, 2021

Conversation

fshipy
Copy link
Contributor

@fshipy fshipy commented Apr 28, 2021 •
edited by fritzo
Loading

Fixes #2827

If some parameters are not used to produce the outputs, the gradients can be None. In this case, an error will be raised because of the addition between None and Tensor.

@fshipy fshipy mentioned this pull request Apr 28, 2021
Closed
@fshipy fshipy changed the title infer.csis ignore gradient when parameter not used, which has a gradient of None Fix infer.csis to ignore gradient when parameter not used, which has a gradient of None Apr 28, 2021
fritzo
fritzo approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this @fshipy!

@fritzo fritzo merged commit 8246685 into pyro-ppl:dev Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fritzo fritzo fritzo approved these changes

Assignees

No one assigned

Labels

awaiting review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] CSIS error when parameters are not fully used

2 participants

@fshipy @fritzo