migrate from readthedocs configuration file v1 to v2 #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
agreed, nice one Wei |
knaaptime
approved these changes
May 12, 2019
Member
Member
|
@weikang9009 Would you like me to merge this or do you want to wait for @sjsrey's review? |
sjsrey
approved these changes
May 12, 2019
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current readthedocs configuration file for giddy and all the other pysal submodules is v1. As suggested on the readthedocs docs page, version 1 should not be used and I think this is the reason why the giddy docs building failed today https://readthedocs.org/projects/giddy/builds/9054523/
I've tested the updated configuration file (v2) on my fork and the building is successful https://readthedocs.org/projects/giddy-wei/builds/9054554/.