Skip to content

Conversation

@weikang9009
Copy link
Member

No description provided.

@jGaboardi
Copy link
Member

goanpeca/setup-miniconda was absorbed by conda-incubator/setup-miniconda and should be changed to conda-incubator/setup-miniconda@v2 in unittests.yml.

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #165 (9553759) into master (c32134d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   70.46%   70.46%           
=======================================
  Files          15       15           
  Lines        1869     1869           
  Branches      266      266           
=======================================
  Hits         1317     1317           
  Misses        528      528           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32134d...9553759. Read the comment docs.

@jGaboardi
Copy link
Member

In spaghetti and libpysal, we decided to drop testing in Python 3.6 that involved fiona due to the ongoing failures.

@jGaboardi
Copy link
Member

@weikang9009 with the Windows-Python 3.6 exclusion, all tests are passing and this PR is good to go.

@jGaboardi jGaboardi merged commit 8a9bfca into pysal:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants