[WIP] add model csvs rather than pickles #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljwolf Could you let me know how you convert mgwr_example.p to georgia_mgwr_model_frame.csv? I am worried that the values in the csv file is not the same as those in mgwr_example.p once loaded? |
|
@weikang9009 I just did it manually, and was also concerned that the numbers were different. I didn't retain the generation code, though, as it's in the active session on my computer in the UK. Thanks for sorting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this starts to move mgwr from using pickles to using dataframes. This is broken as it stands, though, since the results are different from those I get when I just run the tests.
Not sure if this is seed setting, platform dependence, or what, but the machinery is now there to read in the expected results from a csv and compare
mgwragainst that known csv. I just don't know how to construct the csv to pass the tests, like what seed to use or what numpy the tests expect.