add _etag to schema defaults #1565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Thinking about this further than a quick github web edit (and given the test errors). Maybe the preferred location to address this is in pyeve-swagger? That would need to cover additional fields like _etag, _created, _updated, etc which are all missing |
Member
|
Hi, a quick lookup suggests that yes, eve-swagger might be the right place to look into to address this need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using https://openapi-ts.dev/ to generate frontend types based on our pyeve + pyeve-swagger, however the _etag field is missing from the schema for all pyeve resources, but the If-Match header is present in the generated documentation. This creates a weird issue for us and it'd be great if all fields added by pyeve were actually included in the schema