clean up some string handling cases #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1381 will not alter performanceComparing Summary
|
15 tasks
sydney-runkle
approved these changes
Aug 2, 2024
Contributor
sydney-runkle
left a comment
There was a problem hiding this comment.
Looks great!
I just learned more about &str and Cow<'_, str>. This was easy to review - thanks!
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
Original-commit-hash: c5a4261
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
&strinstead ofCow<'_, str>in a couple places where it's good enoughRelated issue number
N/A
Checklist
pydantic-core(except for expected changes)