- 
                Notifications
    You must be signed in to change notification settings 
- Fork 205
          [Feature] prove * using * command for incremental proof construction
          #783
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            15 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      68c4e16
              
                [add] prove using command
              
              
                AD1024 a6af91e
              
                [add] invariant ref
              
              
                AD1024 c7bfd28
              
                [save] generating queries for proof commands
              
              
                AD1024 51b4fe4
              
                [save] finish commands
              
              
                AD1024 b1e9e8a
              
                save parallization
              
              
                AD1024 fa9e1d4
              
                save
              
              
                AD1024 bf10cd2
              
                save
              
              
                AD1024 714ea7c
              
                save
              
              
                AD1024 c19d188
              
                save
              
              
                AD1024 bf6e107
              
                [save] more tweaks
              
              
                AD1024 83cdec9
              
                remove some commented code
              
              
                AD1024 7317620
              
                [fix] separate sanity check and event handler checks
              
              
                AD1024 08aa8bc
              
                [add] `except` keyword
              
              
                AD1024 a11c558
              
                remove some commented code
              
              
                AD1024 07f3bf5
              
                [fix] generate local state for spec machines
              
              
                AD1024 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
        
          
          
            569 changes: 417 additions & 152 deletions
          
          569 
        
  Src/PCompiler/CompilerCore/Backend/Uclid5/Uclid5CodeGenerator.cs
  
  
      
      
   
        
      
      
    Large diffs are not rendered by default.
      
      Oops, something went wrong.
      
    
  
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            17 changes: 17 additions & 0 deletions
          
          17 
        
  Src/PCompiler/CompilerCore/TypeChecker/AST/Declarations/InvariantGroup.cs
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| using System.Collections.Generic; | ||
| using Antlr4.Runtime; | ||
|  | ||
| namespace Plang.Compiler.TypeChecker.AST.Declarations | ||
| { | ||
| public class InvariantGroup : IPDecl | ||
| { | ||
| public InvariantGroup(string name, ParserRuleContext sourceNode) | ||
| { | ||
| Name = name; | ||
| SourceLocation = sourceNode; | ||
| } | ||
| public List<Invariant> Invariants { get; set; } | ||
| public ParserRuleContext SourceLocation { get; } | ||
| public string Name { get; set; } | ||
| } | ||
| } | 
        
          
          
            22 changes: 22 additions & 0 deletions
          
          22 
        
  Src/PCompiler/CompilerCore/TypeChecker/AST/Declarations/ProofCommand.cs
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using Antlr4.Runtime; | ||
|  | ||
| namespace Plang.Compiler.TypeChecker.AST.Declarations | ||
| { | ||
| public class ProofCommand : IPDecl | ||
| { | ||
| public ProofCommand(string name, ParserRuleContext sourceNode) | ||
| { | ||
| Debug.Assert(sourceNode is PParser.ProofItemContext); | ||
| SourceLocation = sourceNode; | ||
| Name = name; | ||
| } | ||
|  | ||
| public List<Invariant> Goals { get; set; } | ||
| public List<Invariant> Premises { get; set; } | ||
| public List<Invariant> Excepts { get; set; } | ||
| public ParserRuleContext SourceLocation { get; } | ||
| public string Name { get; set; } | ||
| } | ||
| } | 
        
          
          
            35 changes: 35 additions & 0 deletions
          
          35 
        
  Src/PCompiler/CompilerCore/TypeChecker/AST/Expressions/InvariantRefExpr.cs
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| using System.Collections.Generic; | ||
| using Antlr4.Runtime; | ||
| using Plang.Compiler.TypeChecker.AST.Declarations; | ||
| using Plang.Compiler.TypeChecker.Types; | ||
|  | ||
| namespace Plang.Compiler.TypeChecker.AST.Expressions | ||
| { | ||
| public class InvariantRefExpr : IPExpr | ||
| { | ||
| public InvariantRefExpr(Invariant inv, ParserRuleContext sourceLocation) | ||
| { | ||
| Invariant = inv; | ||
| SourceLocation = sourceLocation; | ||
| } | ||
| public Invariant Invariant { get; set; } | ||
|  | ||
| public PLanguageType Type => PrimitiveType.Bool; | ||
|  | ||
| public ParserRuleContext SourceLocation { get; set; } | ||
| } | ||
|  | ||
| public class InvariantGroupRefExpr : IPExpr { | ||
| public InvariantGroupRefExpr(InvariantGroup invGroup, ParserRuleContext sourceLocation) | ||
| { | ||
| InvariantGroup = invGroup; | ||
| SourceLocation = sourceLocation; | ||
| } | ||
| public InvariantGroup InvariantGroup { get; set; } | ||
| public List<Invariant> Invariants => InvariantGroup.Invariants; | ||
|  | ||
| public PLanguageType Type => PrimitiveType.Bool; | ||
|  | ||
| public ParserRuleContext SourceLocation { get; set; } | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example that uses the "except" keyword? I'm not totally sure I understand what it does. Is it just like commenting an invariant out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AD1024 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, essentially it is excluding invariants from goals and premises.
For example, if you write
prove X using *and you do not want to put Y in the*, then you can writeprove X using * except Y.Also, if you write
prove *and do not want to includeYin*, you can writeprove * except Y.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool, looks good to me!