Fix copy & paste typo in flattenStructExpression #5322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
No simple testcase, we need to have something like header stack inside a struct to trigger the execution. |
ChrisDodd
approved these changes
Jun 16, 2025
…tries are NamedExpressions, so we might peel to underlying expression to recurse further. Signed-off-by: Anton Korobeynikov <[email protected]>
Contributor
Author
|
Looks like this "fixed" one of testgen tests :) |
Contributor
Author
|
@fruffy looks like this fixed couple of testgen xfails. Will you please take a look? |
Signed-off-by: Anton Korobeynikov <[email protected]>
Collaborator
It does, at least on the P4Testgen side. Great! The BMv2 tests are still failing because of compilation issues. I would just update the xfails there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructExpression entries are NamedExpressions, so we might peel to underlying expression to recurse further.