Decimal numbers support for the json lib #5283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stan-leetasi <[email protected]>
fruffy
approved these changes
May 18, 2025
ChrisDodd
approved these changes
May 19, 2025
Contributor
ChrisDodd
left a comment
There was a problem hiding this comment.
Is there any backend that needs floating point values in json?
Contributor
Author
The decimal point support is utilized by a new extension to the frontend, which collects and exports code metrics: #5250. Some metric values are floats, so I decided to extend the JSON library to support this functionality. |
Contributor
Author
|
Are there any other changes that need to be made, or can this PR be merged? |
Collaborator
Seems like no one else has concerns so we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the JSON library's functionality by enabling it to print decimal numbers. Numeric values are now printed in a form that matches their type: whole numbers are printed without a decimal point, and decimal numbers retain their fractional part. The
Valueenum value was split intoIntegerandFloat. Thevaluefield was also replaced, withintValueandfloatValuefields. Tests for this new functionality were also added tojson_test.cpp