Extension to strength reduction for issue 5280 #5281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChrisDodd
commented
May 17, 2025
- swap operands to Add when left is a constant.
fruffy
reviewed
May 18, 2025
fc7cd4a to
808daf6
Compare
Contributor
Author
|
I extended this to other commutative operators (mul and binary and/or/xor), as well as addiing the missing support for AddSat and SubSat. |
808daf6 to
e7ae6e7
Compare
Collaborator
|
The P4Testgen tests are likely failing because some expressions are reordered. The tests are in |
f006029 to
fed3233
Compare
fed3233 to
83d789c
Compare
83d789c to
390eeb2
Compare
a240720 to
f1e4a65
Compare
- swap operands to commutative ops when left is a constant. - add support for AddSat and SubSat Signed-off-by: Chris Dodd <[email protected]>
- use Sub instead of Add so it won't be swapped by StrengthReduction Signed-off-by: Chris Dodd <[email protected]>
fruffy
approved these changes
Aug 18, 2025
jhavrane
pushed a commit
to jhavrane/p4c
that referenced
this pull request
Dec 19, 2025
Signed-off-by: Chris Dodd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.