Skip to content

[bmv2]: support Random extern for psa/pna #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grg merged 1 commit into from
Apr 2, 2025
Merged

[bmv2]: support Random extern for psa/pna #5213

grg merged 1 commit into from
Apr 2, 2025

Conversation

@grg
Copy link
Contributor

@grg grg commented Apr 1, 2025 •
edited
Loading

Fix the following error with PSA/PNA Random:

vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)

@github-actions github-actions bot added the bmv2 Topics related to BMv2 or v1model label Apr 1, 2025
@grg
Copy link
Contributor Author

grg commented Apr 1, 2025

Good job, github-actions bot. You successfully added a label today! 🙂

@grg grg marked this pull request as ready for review April 2, 2025 00:31
@grg grg requested review from antoninbas, fruffy and jafingerhut April 2, 2025 00:31
jafingerhut
jafingerhut approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grg grg added this pull request to the merge queue Apr 2, 2025
Merged via the queue into p4lang:main with commit 5cec317 Apr 2, 2025
23 checks passed
@grg grg deleted the gleng/bmv2_psa_pna_random branch April 2, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

@antoninbas antoninbas Awaiting requested review from antoninbas

@fruffy fruffy Awaiting requested review from fruffy

Assignees

No one assigned

Labels

bmv2 Topics related to BMv2 or v1model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grg @jafingerhut