Skip to content

[lit-html] Re-work async directives for better gc behavior #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinpschaaf merged 22 commits into from
Aug 19, 2021
Merged

[lit-html] Re-work async directives for better gc behavior #2044

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7f866e9
Re-work async directives for better gc behavior
kevinpschaaf Aug 10, 2021
bbb495a
Add changeset
kevinpschaaf Aug 10, 2021
0c117f5
Updates based on feedback
kevinpschaaf Aug 11, 2021
c427f64
Fix typo
kevinpschaaf Aug 11, 2021
35bcf65
Remove unused import
kevinpschaaf Aug 11, 2021
81d9cc2
Remove unused argument
kevinpschaaf Aug 16, 2021
64edad4
Add memory.ts
kevinpschaaf Aug 17, 2021
612f75c
Replace forceGC with window.gc
kevinpschaaf Aug 17, 2021
92d5acd
Factor connect/disconnect logic into DisconnectableAwaiter
kevinpschaaf Aug 17, 2021
e19f78d
Fix infinity
kevinpschaaf Aug 17, 2021
e90afa8
Add test of same promise passed to two instances of until
kevinpschaaf Aug 18, 2021
8e671e4
Add test of same iterable passed to two directives
kevinpschaaf Aug 18, 2021
90d1fca
Remove weakmap
kevinpschaaf Aug 18, 2021
1ce06c6
Refactor helper logic
kevinpschaaf Aug 18, 2021
8ff1f62
Initialize value
kevinpschaaf Aug 18, 2021
0c158e6
Remove extra factored method
kevinpschaaf Aug 18, 2021
b557978
Cleanup
kevinpschaaf Aug 18, 2021
4f5e512
Cleanup
kevinpschaaf Aug 18, 2021
5b15456
Cleanup based on review
kevinpschaaf Aug 18, 2021
b707edd
Cleanup
kevinpschaaf Aug 18, 2021
38b82fa
Fix copyright
kevinpschaaf Aug 18, 2021
0b6386b
Feedback based on review
kevinpschaaf Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@kevinpschaaf
kevinpschaaf committed Aug 18, 2021
commit 4f5e51292ef489efe5027dc7f5e6a286f4c1f932
2 changes: 2 additions & 0 deletions packages/lit-html/src/directives/async-replace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ export class AsyncReplaceDirective extends AsyncDirective {
}

update(_part: ChildPart, [value, mapper]: DirectiveParameters<this>) {
// If our initial render occurs while disconnected, ensure that the pauser
// and weakThis are in the disconnected state
if (!this.isConnected) {
this.disconnected();
}
Expand Down