Add support for "private" custom elements #1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In typescript, users can specify a private constructor to prevent
subclassing
```ts
class XFoo extends HTMLElement {
private constructor() {
super();
}
}
```
In order to support this construction with `@customElement`, we have to
switch from using `Constructor<HTMLElement>` to `Omit<typeof
HTMLElement, 'new'>`.
justinfagnani
approved these changes
Jun 9, 2021
justinfagnani
added a commit
that referenced
this pull request
Aug 19, 2021
justinfagnani
added a commit
that referenced
this pull request
Aug 19, 2021
* Add SSR global demo changeset * Add changeset for types cleanup * Add CSSResult check changeset * Add changeset for #1937 * Add changeset for #1943 * Add changeset for #1964 * Add changeset for #2050 * Add missing changesets Co-authored-by: Kevin Schaaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript, users can specify a private constructor to prevent
subclassing
In order to support this construction with
@customElement, we have toswitch from using
Constructor<HTMLElement>toOmit<typeof HTMLElement, 'new'>.