Skip to content

[labs/tsserver-plugin] Optimize tests by reusing the language service. #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rictic merged 3 commits into from
Aug 27, 2025
Merged

[labs/tsserver-plugin] Optimize tests by reusing the language service. #5070

rictic merged 3 commits into from
Aug 27, 2025

Conversation

@rictic
Copy link
Collaborator

@rictic rictic commented Aug 27, 2025

Each test file still runs in its own process so this is just for tests in the same file.

@rictic rictic requested a review from kevinpschaaf as a code owner August 27, 2025 18:59
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ab2742b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit-labs/tsserver-plugin Patch
@lit-labs/vscode-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +13% (-0.01ms - +1.41ms)
    this-change vs tip-of-tree

render

  • this-change: 41.57ms - 51.55ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +1% (-1.47ms - +0.29ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.44ms - +1.12ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -14% - +43% (-6.20ms - +21.57ms)
    this-change vs tip-of-tree

update

  • this-change: 456.58ms - 465.03ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +11% (-0.23ms - +3.89ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.34ms - +2.04ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-8.91ms - +6.01ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 444.07ms - 451.95ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.72ms - +6.41ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
41.57ms - 51.55ms-

update

VersionAvg timevs
456.58ms - 465.03ms-

update-reflect

VersionAvg timevs
444.07ms - 451.95ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.34ms - 20.50ms-unsure 🔍
-7% - +1%
-1.47ms - +0.29ms		unsure 🔍
-5% - +3%
-0.94ms - +0.64ms
tip-of-tree
tip-of-tree		19.85ms - 21.17msunsure 🔍
-2% - +7%
-0.29ms - +1.47ms		-unsure 🔍
-2% - +6%
-0.42ms - +1.29ms
previous-release
previous-release		19.54ms - 20.62msunsure 🔍
-3% - +5%
-0.64ms - +0.94ms		unsure 🔍
-6% - +2%
-1.29ms - +0.42ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
37.15ms - 39.72ms-unsure 🔍
-1% - +11%
-0.23ms - +3.89ms		unsure 🔍
-2% - +8%
-0.82ms - +2.94ms
tip-of-tree
tip-of-tree		35.00ms - 38.21msunsure 🔍
-10% - +0%
-3.89ms - +0.23ms		-unsure 🔍
-8% - +4%
-2.88ms - +1.34ms
previous-release
previous-release		36.01ms - 38.75msunsure 🔍
-8% - +2%
-2.94ms - +0.82ms		unsure 🔍
-4% - +8%
-1.34ms - +2.88ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.17ms - 12.40ms-unsure 🔍
-0% - +13%
-0.01ms - +1.41ms		unsure 🔍
-5% - +8%
-0.53ms - +0.95ms
tip-of-tree
tip-of-tree		10.72ms - 11.44msunsure 🔍
-12% - -0%
-1.41ms - +0.01ms		-unsure 🔍
-9% - +0%
-1.04ms - +0.06ms
previous-release
previous-release		11.15ms - 11.99msunsure 🔍
-8% - +4%
-0.95ms - +0.53ms		unsure 🔍
-1% - +9%
-0.06ms - +1.04ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
35.00ms - 36.18ms-unsure 🔍
-1% - +3%
-0.44ms - +1.12ms		unsure 🔍
-2% - +3%
-0.61ms - +1.03ms
tip-of-tree
tip-of-tree		34.74ms - 35.76msunsure 🔍
-3% - +1%
-1.12ms - +0.44ms		-unsure 🔍
-3% - +2%
-0.89ms - +0.63ms
previous-release
previous-release		34.81ms - 35.95msunsure 🔍
-3% - +2%
-1.03ms - +0.61ms		unsure 🔍
-2% - +3%
-0.63ms - +0.89ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
72.30ms - 74.70ms-unsure 🔍
-2% - +3%
-1.34ms - +2.04ms		unsure 🔍
-4% - +0%
-3.04ms - +0.22ms
tip-of-tree
tip-of-tree		71.96ms - 74.34msunsure 🔍
-3% - +2%
-2.04ms - +1.34ms		-faster ✔
0% - 4%
0.14ms - 3.38ms
previous-release
previous-release		73.81ms - 76.01msunsure 🔍
-0% - +4%
-0.22ms - +3.04ms		slower ❌
0% - 5%
0.14ms - 3.38ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
49.85ms - 70.09ms-unsure 🔍
-14% - +43%
-6.20ms - +21.57ms		unsure 🔍
-9% - +52%
-3.02ms - +24.11ms
tip-of-tree
tip-of-tree		42.78ms - 61.80msunsure 🔍
-34% - +9%
-21.57ms - +6.20ms		-unsure 🔍
-21% - +33%
-10.25ms - +15.98ms
previous-release
previous-release		40.39ms - 58.46msunsure 🔍
-38% - +3%
-24.11ms - +3.02ms		unsure 🔍
-30% - +19%
-15.98ms - +10.25ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
461.72ms - 473.23ms-unsure 🔍
-2% - +1%
-8.91ms - +6.01ms		unsure 🔍
-1% - +2%
-6.26ms - +8.70ms
tip-of-tree
tip-of-tree		464.18ms - 473.66msunsure 🔍
-1% - +2%
-6.01ms - +8.91ms		-unsure 🔍
-1% - +2%
-4.06ms - +9.39ms
previous-release
previous-release		461.48ms - 471.03msunsure 🔍
-2% - +1%
-8.70ms - +6.26ms		unsure 🔍
-2% - +1%
-9.39ms - +4.06ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
467.42ms - 477.05ms-unsure 🔍
-1% - +1%
-6.72ms - +6.41ms		unsure 🔍
-2% - +1%
-7.77ms - +5.47ms
tip-of-tree
tip-of-tree		467.92ms - 476.86msunsure 🔍
-1% - +1%
-6.41ms - +6.72ms		-unsure 🔍
-2% - +1%
-7.36ms - +5.38ms
previous-release
previous-release		468.83ms - 477.92msunsure 🔍
-1% - +2%
-5.47ms - +7.77ms		unsure 🔍
-1% - +2%
-5.38ms - +7.36ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

The size of lit-html.js and lit-core.min.js are as expected.

justinfagnani
justinfagnani approved these changes Aug 27, 2025
View reviewed changes
packages/labs/tsserver-plugin/src/test/lib/lit-expression-type_test.ts
};
return ts.createProgram([fakeTypesPath], options);
function getProgram(): ts.Program {
using cleanup = getReusableTestProjectService();
Copy link
Collaborator

@justinfagnani justinfagnani Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@justinfagnani justinfagnani changed the title Optimize tests by reusing the language service. [labs/tsserver-plugin] Optimize tests by reusing the language service. Aug 27, 2025
@rictic rictic merged commit 19343ee into main Aug 27, 2025
10 checks passed
@rictic rictic deleted the optimize-tsserver-tests branch August 27, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rictic @justinfagnani