fix(lit-html): handle mock document without createTreeWalker #5065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4855
Update the
documentselection logic inlit-html.tsto also check whetherdocument.createTreeWalkeris a function:If the function is missing, lit-html falls back to its internal mock.
Did not add a unit test here, since the fallback path is decided at module evaluation time (const d = ...), and in the existing test files lit-html is already imported at the top.
This makes it impossible to toggle document.createTreeWalker before the module loads without introducing brittle dynamic-import tricks or extracting a new helper function, which I wanted to avoid to keep this fix minimal.