Skip to content

[ci] fix two broken CI issues #4991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

[ci] fix two broken CI issues #4991

merged 1 commit into from
May 19, 2025

Conversation

@e111077
Copy link
Contributor

@e111077 e111077 commented May 17, 2025 •
edited
Loading

CI is broken based on the kernel used by GH Actions. We are using unbuntu-latest. See this CI error. Pretty sure we can trust the content we are running so we should be able to just turn the sandbox off since this just generates an image.

It was also broken because it seems that Vue introduced a new hidden slot with the slotname __ which seems to hold metadata we were not expecting. Related CI failure

Parent Children
(main) #4970

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 713bc4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lit-labs/vue-utils Patch
@lit-internal/scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@e111077 e111077 marked this pull request as ready for review May 17, 2025 02:53
@e111077 e111077 requested a review from kevinpschaaf as a code owner May 17, 2025 02:53
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: slower ❌ 3% - 24% (0.44ms - 3.02ms)
    this-change vs tip-of-tree

render

  • this-change: 43.59ms - 56.69ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-0.73ms - +0.55ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.65ms - +0.59ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +49% (-3.05ms - +26.65ms)
    this-change vs tip-of-tree

update

  • this-change: 498.62ms - 506.72ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +8% (-0.47ms - +3.36ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.83ms - +3.45ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-8.75ms - +4.18ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 487.29ms - 494.54ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-7.99ms - +3.97ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
43.59ms - 56.69ms-

update

VersionAvg timevs
498.62ms - 506.72ms-

update-reflect

VersionAvg timevs
487.29ms - 494.54ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
19.36ms - 20.46ms-unsure 🔍
-4% - +3%
-0.73ms - +0.55ms		unsure 🔍
-3% - +4%
-0.52ms - +0.84ms
tip-of-tree
tip-of-tree		19.67ms - 20.34msunsure 🔍
-3% - +4%
-0.55ms - +0.73ms		-unsure 🔍
-1% - +4%
-0.27ms - +0.77ms
previous-release
previous-release		19.35ms - 20.15msunsure 🔍
-4% - +3%
-0.84ms - +0.52ms		unsure 🔍
-4% - +1%
-0.77ms - +0.27ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
40.07ms - 43.29ms-unsure 🔍
-1% - +8%
-0.47ms - +3.36ms		unsure 🔍
-3% - +7%
-1.19ms - +2.85ms
tip-of-tree
tip-of-tree		39.20ms - 41.28msunsure 🔍
-8% - +1%
-3.36ms - +0.47ms		-unsure 🔍
-5% - +2%
-2.22ms - +1.00ms
previous-release
previous-release		39.62ms - 42.07msunsure 🔍
-7% - +3%
-2.85ms - +1.19ms		unsure 🔍
-3% - +6%
-1.00ms - +2.22ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
13.36ms - 15.43ms-slower ❌
3% - 24%
0.44ms - 3.02ms		unsure 🔍
-2% - +20%
-0.15ms - +2.56ms
tip-of-tree
tip-of-tree		11.90ms - 13.43msfaster ✔
4% - 20%
0.44ms - 3.02ms		-unsure 🔍
-13% - +5%
-1.69ms - +0.63ms
previous-release
previous-release		12.32ms - 14.06msunsure 🔍
-17% - +1%
-2.56ms - +0.15ms		unsure 🔍
-5% - +13%
-0.63ms - +1.69ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.64ms - 37.43ms-unsure 🔍
-2% - +2%
-0.65ms - +0.59ms		unsure 🔍
-1% - +2%
-0.28ms - +0.90ms
tip-of-tree
tip-of-tree		36.59ms - 37.55msunsure 🔍
-2% - +2%
-0.59ms - +0.65ms		-unsure 🔍
-1% - +3%
-0.31ms - +0.99ms
previous-release
previous-release		36.29ms - 37.17msunsure 🔍
-2% - +1%
-0.90ms - +0.28ms		unsure 🔍
-3% - +1%
-0.99ms - +0.31ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
85.72ms - 88.64ms-unsure 🔍
-1% - +4%
-0.83ms - +3.45ms		unsure 🔍
-2% - +3%
-1.60ms - +2.32ms
tip-of-tree
tip-of-tree		84.30ms - 87.43msunsure 🔍
-4% - +1%
-3.45ms - +0.83ms		-unsure 🔍
-3% - +1%
-2.99ms - +1.10ms
previous-release
previous-release		85.50ms - 88.12msunsure 🔍
-3% - +2%
-2.32ms - +1.60ms		unsure 🔍
-1% - +3%
-1.10ms - +2.99ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
59.04ms - 80.41ms-unsure 🔍
-8% - +49%
-3.05ms - +26.65ms		unsure 🔍
-8% - +48%
-3.42ms - +26.47ms
tip-of-tree
tip-of-tree		47.60ms - 68.24msunsure 🔍
-36% - +3%
-26.65ms - +3.05ms		-unsure 🔍
-26% - +25%
-14.96ms - +14.41ms
previous-release
previous-release		47.75ms - 68.64msunsure 🔍
-36% - +3%
-26.47ms - +3.42ms		unsure 🔍
-25% - +26%
-14.41ms - +14.96ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
494.92ms - 504.56ms-unsure 🔍
-2% - +1%
-8.75ms - +4.18ms		unsure 🔍
-2% - +0%
-10.81ms - +1.60ms
tip-of-tree
tip-of-tree		497.72ms - 506.33msunsure 🔍
-1% - +2%
-4.18ms - +8.75ms		-unsure 🔍
-2% - +1%
-8.13ms - +3.50ms
previous-release
previous-release		500.44ms - 508.25msunsure 🔍
-0% - +2%
-1.60ms - +10.81ms		unsure 🔍
-1% - +2%
-3.50ms - +8.13ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
508.70ms - 517.57ms-unsure 🔍
-2% - +1%
-7.99ms - +3.97ms		unsure 🔍
-2% - +1%
-9.78ms - +2.93ms
tip-of-tree
tip-of-tree		511.13ms - 519.16msunsure 🔍
-1% - +2%
-3.97ms - +7.99ms		-unsure 🔍
-1% - +1%
-7.48ms - +4.65ms
previous-release
previous-release		512.01ms - 521.11msunsure 🔍
-1% - +2%
-2.93ms - +9.78ms		unsure 🔍
-1% - +1%
-4.65ms - +7.48ms		-

tachometer-reporter-action v2 for Benchmarks

@e111077 e111077 mentioned this pull request May 17, 2025
Merged
@github-actions
Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

@e111077 e111077 force-pushed the fix-release-image-sandbox-issue branch from 2917551 to 8a6ec41 Compare May 17, 2025 02:59
@e111077
[ci] fix release image sandbox error
713bc4f 
CI is broken based on the kernel used by GH Actions. We are using unbuntu-latest. [See this CI error](https://github.com/lit/lit/actions/runs/15080547701/job/42397010351?pr=4970). Pretty sure we can trust the content we are running so we should be able to just turn the sandbox off since this just generates an image.
@e111077 e111077 force-pushed the fix-release-image-sandbox-issue branch from 8a6ec41 to 713bc4f Compare May 17, 2025 04:13
@e111077 e111077 changed the title [ci] fix release image sandbox error [ci] fix two broken CI issues May 17, 2025
justinfagnani
justinfagnani approved these changes May 17, 2025
View reviewed changes
Copy link
Collaborator

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@e111077 e111077 merged commit 909ea73 into main May 19, 2025
10 checks passed
@e111077 e111077 deleted the fix-release-image-sandbox-issue branch May 19, 2025 06:08
@lit-robot lit-robot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e111077 @justinfagnani