-
Notifications
You must be signed in to change notification settings - Fork 1k
[all] A bunch of README updates #4997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cleans up notices about old prereleases, adds badges and doc links, adds docs to observers.
🦋 Changeset detectedLatest commit: a0f91b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
|
The size of lit-html.js and lit-core.min.js are as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
made suggestions for adding mdn links to the respective observers for the @lit-labs/observer package, and a fix a target url for lit-element.
Co-authored-by: Augustine Kim <[email protected]>
| @@ -1,5 +1,17 @@ | |||
| # @lit/context | |||
|
|
|||
| Make data available to entire component subtrees with the context protocol | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: do we clarify what “THE context protocol” is elsewhere? Just to clarify it’s a community protocol and not just lit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll add "WCCG" and a link here.
| Lit 2.x and 3.0 are _interoperable_: templates, base classes, directives, decorators, etc., from one version of Lit will work with those from another. | ||
|
|
||
| Please file any issues you find on our [issue tracker](https://github.com/lit/lit/issues). | ||
| When using `lit-html` to develop web components, most users should import lit-html via the [`lit`](https://www.npmjs.com/package/lit) package rather than installing and importing from `lit-html` directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want non wc users to use this package or lit as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a few cases where you might want to install lit-html directly, but I don't know if we need to list them, which is why this says "most". (you could still be building web components, but without LitElement, for examples).
|
Oops, I didn't realize that my git push had failed locally and I merged with a couple of hanging changes. |
Cleans up notices about old prereleases, adds badges and doc links, adds docs to observers.
Fixes #4996