Implement the full CustomElementRegistry type for the ssr shim. #4987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves fidelity, and by making the class a declaration rather than an expression, and explicitly implementing the real interface we're able to better cooperate with JSCompiler's renaming.
🦋 Changeset detectedLatest commit: 4f135e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Tachometer Benchmark ResultsSummarynop-update
render
update
update-reflect
Resultsthis-change
render
update
update-reflect
this-change, tip-of-tree, previous-release
render
update
nop-update
this-change, tip-of-tree, previous-release
render
update
this-change, tip-of-tree, previous-release
render
update
update-reflect
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the server-side rendering shim by fully implementing the CustomElementRegistry type, ensuring better type fidelity and improved compatibility with JSCompiler renaming.
- Introduces a full class implementation for CustomElementRegistry with additional methods (getName, upgrade, whenDefined)
- Adds helper types and functions to manage asynchronous element definition resolution
- Updates export statements to align with the new type declarations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/labs/ssr-dom-shim/src/index.ts | Implements a complete CustomElementRegistry type with added methods and helper types for improved fidelity. |
| .changeset/rare-dryers-jump.md | Minor changeset documentation describing the update. |
Contributor
|
The size of lit-html.js and lit-core.min.js are as expected. |
justinfagnani
approved these changes
May 14, 2025
Comment on lines
+186
to
+192
| let resolve: (value: T) => void; | ||
| let reject: (reason?: unknown) => void; | ||
| const promise = new Promise<T>((res, rej) => { | ||
| resolve = res; | ||
| reject = rej; | ||
| }); | ||
| return {promise, resolve: resolve!, reject: reject!}; |
Collaborator
There was a problem hiding this comment.
fyi, you can do slightly more compact non-null assertions:
Suggested change
| let resolve: (value: T) => void; | |
| let reject: (reason?: unknown) => void; | |
| const promise = new Promise<T>((res, rej) => { | |
| resolve = res; | |
| reject = rej; | |
| }); | |
| return {promise, resolve: resolve!, reject: reject!}; | |
| let resolve!: (value: T) => void; | |
| let rejec!t: (reason?: unknown) => void; | |
| const promise = new Promise<T>((res, rej) => { | |
| resolve = res; | |
| reject = rej; | |
| }); | |
| return {promise, resolve, reject}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves fidelity, and by making the class a declaration rather than an expression, and explicitly implementing the real interface we're able to better cooperate with JSCompiler's renaming.