Skip to content

fromAttribute can set the property to either null or undefined. #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rictic merged 6 commits into from
May 5, 2025
Merged

fromAttribute can set the property to either null or undefined. #4976

rictic merged 6 commits into from
May 5, 2025

Conversation

@rictic
Copy link
Collaborator

@rictic rictic commented Apr 14, 2025

Fixes a regression from #4934 which collapsed all converted nullish values to null.

@rictic
fromAttribute can set the property to either null or undefined.
94ccb27 
Fixes a regression from #4934 which collapsed all converted nullish values to null.
@rictic rictic requested a review from kevinpschaaf as a code owner April 14, 2025 20:00
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1fe2296

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
lit Patch
lit-element Patch
@lit/reactive-element Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rictic rictic requested review from Copilot and sorvell and removed request for Copilot and kevinpschaaf April 14, 2025 20:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -10% - +11% (-1.21ms - +1.39ms)
    this-change vs tip-of-tree

render

  • this-change: 42.97ms - 55.03ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +2% (-0.89ms - +0.42ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.17ms - +0.67ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -34% - +14% (-21.22ms - +9.20ms)
    this-change vs tip-of-tree

update

  • this-change: 476.84ms - 481.96ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +4% (-2.25ms - +1.54ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +4% (-0.38ms - +2.62ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.85ms - +5.43ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 465.30ms - 470.68ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-8.62ms - +3.49ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
42.97ms - 55.03ms-

update

VersionAvg timevs
476.84ms - 481.96ms-

update-reflect

VersionAvg timevs
465.30ms - 470.68ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
17.90ms - 18.87ms-unsure 🔍
-5% - +2%
-0.89ms - +0.42ms		faster ✔
0% - 8%
0.05ms - 1.51ms
tip-of-tree
tip-of-tree		18.18ms - 19.06msunsure 🔍
-2% - +5%
-0.42ms - +0.89ms		-unsure 🔍
-6% - +1%
-1.24ms - +0.15ms
previous-release
previous-release		18.62ms - 19.71msslower ❌
0% - 8%
0.05ms - 1.51ms		unsure 🔍
-1% - +7%
-0.15ms - +1.24ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.98ms - 37.75ms-unsure 🔍
-6% - +4%
-2.25ms - +1.54ms		unsure 🔍
-8% - +2%
-2.98ms - +0.83ms
tip-of-tree
tip-of-tree		35.42ms - 38.01msunsure 🔍
-4% - +6%
-1.54ms - +2.25ms		-unsure 🔍
-7% - +3%
-2.56ms - +1.11ms
previous-release
previous-release		36.14ms - 38.74msunsure 🔍
-2% - +8%
-0.83ms - +2.98ms		unsure 🔍
-3% - +7%
-1.11ms - +2.56ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
11.85ms - 13.86ms-unsure 🔍
-10% - +11%
-1.21ms - +1.39ms		unsure 🔍
-14% - +7%
-1.84ms - +0.91ms
tip-of-tree
tip-of-tree		11.93ms - 13.59msunsure 🔍
-11% - +9%
-1.39ms - +1.21ms		-unsure 🔍
-13% - +5%
-1.81ms - +0.70ms
previous-release
previous-release		12.38ms - 14.26msunsure 🔍
-7% - +14%
-0.91ms - +1.84ms		unsure 🔍
-6% - +14%
-0.70ms - +1.81ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
34.41ms - 35.11ms-unsure 🔍
-1% - +2%
-0.17ms - +0.67ms		unsure 🔍
-2% - +1%
-0.74ms - +0.42ms
tip-of-tree
tip-of-tree		34.28ms - 34.75msunsure 🔍
-2% - +0%
-0.67ms - +0.17ms		-unsure 🔍
-3% - +0%
-0.93ms - +0.11ms
previous-release
previous-release		34.46ms - 35.39msunsure 🔍
-1% - +2%
-0.42ms - +0.74ms		unsure 🔍
-0% - +3%
-0.11ms - +0.93ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
69.83ms - 71.93ms-unsure 🔍
-1% - +4%
-0.38ms - +2.62ms		unsure 🔍
-1% - +3%
-0.57ms - +2.18ms
tip-of-tree
tip-of-tree		68.69ms - 70.83msunsure 🔍
-4% - +1%
-2.62ms - +0.38ms		-unsure 🔍
-2% - +2%
-1.71ms - +1.07ms
previous-release
previous-release		69.19ms - 70.97msunsure 🔍
-3% - +1%
-2.18ms - +0.57ms		unsure 🔍
-2% - +2%
-1.07ms - +1.71ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
43.76ms - 64.87ms-unsure 🔍
-34% - +14%
-21.22ms - +9.20ms		unsure 🔍
-29% - +24%
-16.12ms - +13.68ms
tip-of-tree
tip-of-tree		49.37ms - 71.28msunsure 🔍
-18% - +41%
-9.20ms - +21.22ms		-unsure 🔍
-20% - +37%
-10.40ms - +19.98ms
previous-release
previous-release		45.02ms - 66.05msunsure 🔍
-25% - +30%
-13.68ms - +16.12ms		unsure 🔍
-32% - +16%
-19.98ms - +10.40ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
495.20ms - 503.83ms-unsure 🔍
-1% - +1%
-6.85ms - +5.43ms		unsure 🔍
-2% - +0%
-10.81ms - +2.25ms
tip-of-tree
tip-of-tree		495.86ms - 504.59msunsure 🔍
-1% - +1%
-5.43ms - +6.85ms		-unsure 🔍
-2% - +1%
-10.14ms - +2.99ms
previous-release
previous-release		498.90ms - 508.70msunsure 🔍
-0% - +2%
-2.25ms - +10.81ms		unsure 🔍
-1% - +2%
-2.99ms - +10.14ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
501.29ms - 509.59ms-unsure 🔍
-2% - +1%
-8.62ms - +3.49ms		unsure 🔍
-1% - +1%
-4.37ms - +6.21ms
tip-of-tree
tip-of-tree		503.60ms - 512.42msunsure 🔍
-1% - +2%
-3.49ms - +8.62ms		-unsure 🔍
-0% - +2%
-2.01ms - +8.98ms
previous-release
previous-release		501.24ms - 507.81msunsure 🔍
-1% - +1%
-6.21ms - +4.37ms		unsure 🔍
-2% - +0%
-8.98ms - +2.01ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

The size of lit-html.js and lit-core.min.js are as expected.

augustjk
augustjk reviewed May 3, 2025
View reviewed changes
@rictic rictic enabled auto-merge (squash) May 5, 2025 21:29
@rictic rictic merged commit a126d8d into main May 5, 2025
10 checks passed
@rictic rictic deleted the fromattr-undefined branch May 5, 2025 21:48
@lit-robot lit-robot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augustjk augustjk augustjk left review comments

@justinfagnani justinfagnani justinfagnani approved these changes

@sorvell sorvell Awaiting requested review from sorvell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rictic @justinfagnani @augustjk