fix(lit-html): import trusted-types/lib barrel explicitly.
#4956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b4cb4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
augustjk
reviewed
Mar 29, 2025
Member
augustjk
left a comment
There was a problem hiding this comment.
thanks! just some minor suggestions.
- Bump lit - Replace pinned ws import by wildcard - Typo Co-authored-by: Augustine Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4943
Import barrels from trusted-types/lib explicitly for compatibility with modern Node resolution.
I added a minimal test project and cover for a few module/moduleResolution pairs that I think are likely to be used with Lit.
This is related in some ways to
https://github.com/lit/lit/blob/main/CONTRIBUTING.md#typescript.
trusted-typeswas imported as an implicit directory index file (aka barrel), which is not supported with the module resolution algorithm of NodeJS (w/ ESM): https://nodejs.org/api/esm.html#mandatory-file-extensions.