[localize] Move setup code to own file to resolve import loop #4679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0cc69a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Localize has an import loop, because submodules are importing from their root. To resolve this `msg`, `installed` and `_installMsgImplementation` have moved to a new submodule. Imports to `msg` stay intact, through an explicit export.
43cf76d to
f6932c4
Compare
justinfagnani
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Fixes #4655 -- Move localize setup to resolve import loop Localize has an import loop, because submodules are importing from their root. To resolve this `msg`, `installed` and `_installMsgImplementation` have moved to a new submodule. Imports to `msg` stay intact, through an explicit export.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localize has an import loop because submodules are importing from their root. To resolve the loop,
msg,installedand_installMsgImplementationare moved to a new submodule.Imports to
msgremain intact, through an explicit export.