refactor(app/integration): remove unused request_init_method()
#3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TapEventExt` provides an extension trait interface that we use to extends `linkerd_proxy_api::tap::TapEvent` with additional interfaces for use in integration tests. this commit removes `request_init_path()`. this method was originally added in 3ac6b72 (#154), but was never actually implemented and will only ever panic when invoked. thus, it can be removed. Signed-off-by: katelyn martin <[email protected]>
olix0r
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TapEventExtprovides an extension trait interface that we use to extendslinkerd_proxy_api::tap::TapEventwith additional interfaces for use in integration tests.this commit removes
request_init_path(). this method was originally added in 3ac6b72 (#154), but was never actually implemented and will only ever panic when invoked. thus, it can be removed.