Skip to content

remove opaq logical addr #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

remove opaq logical addr #3309

merged 1 commit into from
Nov 1, 2024

Conversation

@zaharidichev
Copy link
Member

@zaharidichev zaharidichev commented Oct 31, 2024

This change has the following effects:

  • we remove opaq::LogicalAddr
  • we try to preserve the behavior of the endpoint metrics by using the profiles logical addr if we have used profiles for resolution.

@zaharidichev
remove opaq:LogicalAddr
3438561 
Signed-off-by: Zahari Dichev <[email protected]>
@zaharidichev zaharidichev mentioned this pull request Oct 31, 2024
Merged
olix0r
olix0r approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks good to me.

@zaharidichev zaharidichev marked this pull request as ready for review November 1, 2024 09:22
@zaharidichev zaharidichev requested a review from a team as a code owner November 1, 2024 09:22
@zaharidichev zaharidichev merged commit b58c169 into zd/opaq-client-policy-refactor Nov 1, 2024
15 checks passed
@zaharidichev zaharidichev deleted the zd/remove-opaq-logical-addr branch November 1, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olix0r olix0r olix0r approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zaharidichev @olix0r