Add non-deprecated unarchive method #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have we tested that both branches work as expected? |
|
the existing tests check for archiving and unarchiving working properly for iOS 11+ and macOS 13+, which is the majority of use-cases anyways. |
nikhilbedi
reviewed
Oct 17, 2019
nikhilbedi
requested changes
Nov 15, 2019
Adds availability check to either use new api to unarchive data, or fallback to deprecated ones on older ios/mac versions.
nikhilbedi
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds availability check to either use
new api to unarchive data, or fallback
to deprecated ones on older ios/mac
versions.
addresses issue:
#17