Add Line::reversed, Line::midpoint, rename Arc::flipped
#375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8bce59 to
0c30ddf
Compare
dfrg
approved these changes
Sep 4, 2024
src/line.rs
Outdated
| /// Return a copy of this `Line` in the opposite direction. | ||
| #[must_use] | ||
| #[inline] | ||
| pub fn flipped(&self) -> Line { |
There was a problem hiding this comment.
nit: I feel like reversed is a slightly better name for this.
Also, it might be helpful if the comment describes what it does: “Returns a copy of this Line with the end points swapped so that it points in the opposite direction.”
There was a problem hiding this comment.
I'll revise the comment.
The name matches the other flipped that I've added in a previous PR, Arc::flipped.
I think I like reversed better though as well, so will update both.
0c30ddf to
485b1c3
Compare
Line::flipped, Line::midpointLine::reversed, Line::midpoint, rename Arc::flipped
|
@dfrg Updated to also rename |
|
All looks good, thanks! |
|
If there are 2 plausible names, feel free to add the less good one as a doc alias :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.