Fix partial deletion failure leaving system in inconsistent state #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if segment deletion failed partway through (e.g., disk error), some segments would be deleted but an error would be returned. This could leave the system in an inconsistent state where some segments were gone but the log still referenced them. This fix implements a mark-then-delete approach: 1. Mark all segments as deleted first (removes them from read path) 2. Then attempt to delete the actual files 3. If file deletion fails, segments are still marked deleted 4. Remaining files can be cleaned up on next cleanup cycle Changes: - Add `deleted` flag to segment struct - Add `MarkDeleted()` and `IsDeleted()` methods to segment - Add `deleteSegments()` helper to deleteCleaner that implements mark-then-delete pattern - Refactor `applyMessagesLimit`, `applyBytesLimit`, and `applyAgeLimit` to use the new helper - Continue deleting remaining segments even if one fails - Add tests for mark-then-delete behavior Fixes the TODO comments at lines 107-108, 145-146, and 173-175 in delete_cleaner.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if segment deletion failed partway through (e.g., disk error), some segments would be deleted but an error would be returned. This could leave the system in an inconsistent state where some segments were gone but the log still referenced them.
This fix implements a mark-then-delete approach:
Changes:
deletedflag to segment structMarkDeleted()andIsDeleted()methods to segmentdeleteSegments()helper to deleteCleaner that implements mark-then-delete patternapplyMessagesLimit,applyBytesLimit, andapplyAgeLimitto use the new helperFixes the TODO comments at lines 107-108, 145-146, and 173-175 in delete_cleaner.go.