GPU: Add bounds validation for slot bindings and uniform data pushes. #14692
+93
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks right. Could we also check the ShaderCreateInfo structs to make sure they aren't declaring more resources than can be bound? That would catch issues sooner in execution than the binding calls. |
Contributor
Author
|
Good idea, will send out another commit soon. |
slouken
reviewed
Dec 22, 2025
Collaborator
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a bug caused by missing bounds checks in several
SDL_Bind*andSDL_Push*GPU functions that write into fixed-size debug tracking arrays. The fix is to add validation (e.g., first_slot + num_bindings > MAX_*) before those writes to prevent immediate or downstream crashes.Existing Issue(s)
Fixes #14679