You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix file name conflict issue
And sequence number to file name if file already
exists.
Test: Manual - press x many times see that files with suffixes are
created
Bug: http://b/191247811
Fix crash when hovering on manually instrumented async scope
TimerInfo::kApiEvent don't have an "InstrumentedFunction" associated
with them so don't expect one.
Test: profile OrbitTest with manual instrumentation enabled, hover on
a profiling scope in one of the "async" tracks.
Clear viewport dirty flag before rendering
This allows the GlCanvas::Draw() method to update the viewport, which
will correctly mark it as dirty again and trigger a new rendering next
frame.
Fix crash on unhooking function when capture_data is not available
Test: Start Orbit, load preset, unhook a function,
make sure there is no crash.
Bug: http://b/179787649
Update orbit_tracks E2E test
Some tracks are not present on the devkit which fails the test. Changed
the MatchTracks test to handle "or" options for tracks and adjusted the
list of tracks.
Fix issues with frame tracks when loading a capture
When loading a capture, Orbit can be in a state where hooking a function
that has hits in the "Live" tab must not be allowed, either because
Orbit is not in a connected state (no process selected) or because the
module to which the function belongs is not loaded. In both these cases,
the "Hook" option is disabled in the "Live" context menu, however it was
incorrectly possible to hook a function by enabling a frame track. In
the connected state, this leads to a crash when taking a capture with
the incorrectly hooked function.
We now apply the same check that is used for enabling the "Hook" context
menu entry when enabling the frame track for a function to make sure
it's only hooked when possible.
Bug: http://b/174296341
Tested: Manual tests for the cases described on the bug.