[PATCH] allow bwa to parse Casava 1.8 fastqs and filterer flagged #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasn't parsing correctly. This patch fixes that and enables bwa to filter sequences marked by Casava, removing this tag from the output. Signed-off-by: RoelKluin <[email protected]>
Owner
|
Thanks. Nonetheless, you should not modify kseq.h. By convention, a FASTA name should not contain any space. Anything beyond space is comment. Allowing space in sequence names as is in the modified kseq.h will cause problems to other input sequences. If you want to get the string after space in the fasta/q header lines, you should check "kseq_t::comment". Could you help to modify using "kseq_t::comment" without touching kseq.h? Thanks. |
…which bwa" This reverts commit 36cd4f9. The comment shouldn't be included in the sequence name.
In Casava 1.8 the fastq output changed. e.g. @EAS139:136:FC706VJ:2:5:1000:12850 1:Y:18:ATCACG AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA + BBBBCCCC?<A?BC?7@@???????DBBA@@@@A@@ The part after the space, treated as comment by bwa, contains the fields: <read number>:<is filtered>:<control number>:<barcode sequence> With `Y' Casava indicates that a sequence should be filtered. This patch enables bwa, with an -Y flag, to filter these sequences. Signed-off-by: Roel Kluin <[email protected]>
pmarks
added a commit
to 10XGenomics/bwa
that referenced
this pull request
Jan 4, 2019
ksprintf is inline, to avoid collision with htslib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Casava 1.8 the fastq output changed, the name has a space which bwa
wasn't parsing correctly. This patch fixes it and enables bwa to filter
sequences marked :Y: by Casava. The tag is removed from the output.
Signed-off-by: RoelKluin [email protected]