Skip to content

Add option to change the Wine graphics driver #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add option to change the Wine graphics driver #6084

wants to merge 3 commits into from
+100 −1

Conversation

@ventureoo
Copy link

Lutris already has option to select Wine audio driver, so in my opinion due to maturation of the winewayland driver, which has been available since Wine 9.0, it makes sense to add option to select Wine graphics backend.

P. S. I'm not sure if paths hardcoding for winewayland is the right solution, so suggestions for an alternative detection of winewayland in selected Wine/Proton version are welcome.

@danieljohnson2
Copy link
Contributor

I like it, but we usually use lowercase for option keys, so maybe "Graphics" should be "graphics". Or perhaps something more specific than that? Maybe "graphics_driver"?

@ventureoo
Copy link
Author

ventureoo commented Apr 27, 2025 •
edited
Loading

I like it, but we usually use lowercase for option keys, so maybe "Graphics" should be "graphics". Or perhaps something more specific than that? Maybe "graphics_driver"?

I'm fine with that, but from set_regedit_keys() I understand that key name from runner_config is passed to wine reg, which is case-insensitive AFAIK, but using graphics_driver is not possible here.

@danieljohnson2
Copy link
Contributor

I didn't appreciate that. Had I understood that, I'd have kept my trap shut. But I guess it can go either way.

@ventureoo
Copy link
Author

I didn't appreciate that. Had I understood that, I'd have kept my trap shut. But I guess it can go either way.

No need to worry. I'll just return everything to the way it was.

@ventureoo ventureoo mentioned this pull request May 17, 2025
Closed
danieljohnson2
danieljohnson2 reviewed May 17, 2025
View reviewed changes
@ventureoo ventureoo force-pushed the winewayland branch 3 times, most recently from e1a652f to 65318b1 Compare May 17, 2025 20:01
@ventureoo ventureoo requested a review from danieljohnson2 May 17, 2025 20:03
@danieljohnson2
Copy link
Contributor

I've put some more review comments in; I don't think we're there yet.

danieljohnson2
danieljohnson2 requested changes May 18, 2025
View reviewed changes
Copy link
Contributor

@danieljohnson2 danieljohnson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I need to do another "review" in GitHub? We're not there yet- I think the registry setting and PROTON_ENABLE_WAYLAND thing should be mutually exclusive, and that the Proton HDR setting should be enabled only when Wayland is first selected, not just when it is available.

@ventureoo ventureoo force-pushed the winewayland branch 2 times, most recently from db9b511 to cdd8a58 Compare May 18, 2025 09:29
danieljohnson2
danieljohnson2 approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@danieljohnson2 danieljohnson2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think this is good enough. I will close my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljohnson2 danieljohnson2 danieljohnson2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ventureoo @danieljohnson2