Skip to content

Allow checkpoint download on non-coordinator process #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Allow checkpoint download on non-coordinator process #3363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3d6c63
always return false if not coordinator
Apr 24, 2023
4f52779
only download artifacts on coordinator
Apr 24, 2023
fb81a3d
allow download for non-coordinator processes
Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions ludwig/trainers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,14 +1079,13 @@ def resume_files_exist(
training_checkpoint_path: str,
) -> bool:
missing_files = []
if self.is_coordinator():
# training_progress.json
if not path_exists(training_progress_tracker_path):
missing_files.append(training_progress_tracker_path)
# latest.ckpt in training_checkpoints/
latest_ckpt = os.path.join(training_checkpoint_path, "latest.ckpt")
if not path_exists(latest_ckpt):
missing_files.append(latest_ckpt)
# training_progress.json
if not path_exists(training_progress_tracker_path):
missing_files.append(training_progress_tracker_path)
# latest.ckpt in training_checkpoints/
latest_ckpt = os.path.join(training_checkpoint_path, "latest.ckpt")
if not path_exists(latest_ckpt):
missing_files.append(latest_ckpt)
if missing_files:
logger.warning(f"Could not find {missing_files} while trying to resume model training.")
return False
Expand Down