Skip to content

Conversation

justinxzhao
Copy link
Contributor

@justinxzhao justinxzhao commented Oct 29, 2021

Primary changes:

  • StackedTransformer: Adjusted the project_to_hidden_size to be initialized with the output shape of the embedding rather than the embedding size. When a sparse representation is specified for the embedding, the embedding's output shape is actually the vocabulary size instead of the embedding size.
  • loss_modules: Add support for specifying class weights using a list.
  • image_utils: Add fallback for num_channels=None. When num_channels isn't specified by the config, finalize_preprocessing actually reads in the first image (or a sample of images) to determine the number of channels.
  • image_utils: During num_channel inference, use the maximum num_channels instead of the average over all samples.
  • test_experiment: Updated image reading to use torchvision.io per offline discussion related to TF to Torch Fix integration test for server #1411, and commented out sequence-output related unit tests.
  • embedding_modules: Implemented output/input shape for TokenAndPositionEmbedding and added a unit test.

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

Unit Test Results

       6 files  ±  0         6 suites  ±0   1h 19m 34s ⏱️ - 4m 40s
2 891 tests  - 11  2 318 ✔️ +28  20 💤 ±0     551  -   39  2 🔥 ±0 
8 673 runs   - 33  6 954 ✔️ +84  60 💤 ±0  1 653  - 117  6 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit feaff7e. ± Comparison against base commit 5e03deb.

♻️ This comment has been updated with latest results.

@w4nderlust w4nderlust merged commit c29105e into tf-to-torch Oct 30, 2021
@w4nderlust w4nderlust deleted the test-experiment branch October 30, 2021 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants