[torch] Fixed Horovod #1439
Merged
[torch] Fixed Horovod #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 3 files + 1 3 suites +1 51m 4s ⏱️ + 13m 0s For more details on these failures and errors, see this check. Results for commit 432812b. ± Comparison against base commit 7a1b82c. ♻️ This comment has been updated with latest results. |
ShreyaR
approved these changes
Oct 28, 2021
| self.optimizer.synchronize() | ||
|
|
||
| # Clip gradients | ||
| self.clipper.clip_grads(variables) |
There was a problem hiding this comment.
Quick question: Why do you want to perform gradient clipping on the parameter values before they were synced?
There was a problem hiding this comment.
In this case it's after they are synced, but before applying the updates. So the ordering is:
optimizer.synchronize(). # waits for allreduce to complete
cliipser.clip_grads() # clips aggregated gradients
optimizer.step() # applies gradients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.