Skip to content

feat(makefile): generate mock auto #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caicloud-bot merged 1 commit into from
Dec 10, 2020
Merged

feat(makefile): generate mock auto #157

caicloud-bot merged 1 commit into from
Dec 10, 2020

Conversation

@simon-cj
Copy link
Contributor

@simon-cj simon-cj commented Dec 10, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Generate mock auto

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @FogDong

Does this PR introduce a user-facing change?:

Generate mock auto

@caicloud-bot caicloud-bot requested a review from FogDong December 10, 2020 05:00
@caicloud-bot caicloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2020
@simon-cj simon-cj changed the title feat(makefile): /kind feature feat(makefile): Generate mock auto Dec 10, 2020
@simon-cj simon-cj changed the title feat(makefile): Generate mock auto feat(makefile): generate mock auto Dec 10, 2020
@simon-cj
Copy link
Contributor Author

simon-cj commented Dec 10, 2020

ping @FogDong

FogDong
FogDong reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@caicloud-bot
Copy link

caicloud-bot commented Dec 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FogDong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@caicloud-bot caicloud-bot merged commit 3d37e45 into kleveross:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FogDong FogDong FogDong left review comments

Assignees

@FogDong FogDong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simon-cj @caicloud-bot @FogDong