feat: Update example model and remove relayout option #115
Conversation
| // For TensorFlow serving, MUST move /mnt/models/model to /mnt/models/1 (dstDir). | ||
| ormbfileBytes, err := ioutil.ReadFile(path.Join(modelDir, "ormbfile.yaml")) | ||
| if err != nil { | ||
| if err := os.Rename(originalDir, path.Join(modelDir, "1")); err != nil { |
There was a problem hiding this comment.
Can we keep 1 in the model content layer?
There was a problem hiding this comment.
I think it is OK. the directory structure will be as follow when ormb push:
--| models
--| model
--| 1
--| xxx.pb
--| ormbfile.yaml
There was a problem hiding this comment.
Yeah, in this way we do not need to have this trick. As you know, other formats such as onnx do not need 1 dir.
There was a problem hiding this comment.
comment are address, PTAL
96c7fcb to
a4b25ad
Compare
a4b25ad to
84dba0b
Compare
1e9a7d5 to
11e35f3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please repush to trigger another build. I decrease the CI test coverage threshold. |
11e35f3 to
33b44e7
Compare
|
New changes are detected. LGTM label has been removed. |
What this PR does / why we need it:
Add your description
For trtserver, all model format must have directory structure as follow when serving:
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #
Special notes for your reviewer:
/cc @gaocegege
Release note: