Skip to content

Conversation

@josunect
Copy link
Contributor

@josunect josunect commented Jan 31, 2025

@josunect josunect self-assigned this Jan 31, 2025
@josunect josunect added the enhancement New feature or request label Jan 31, 2025
Copy link
Contributor

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josune for extending Ambient docs! I have added some optional suggestions and found a small typo at the end.

@josunect josunect requested a review from ferhoyos January 31, 2025 12:19
@josunect
Copy link
Contributor Author

Thanks Josune for extending Ambient docs! I have added some optional suggestions and found a small typo at the end.

thanks for the review!

Copy link
Contributor

@ferhoyos ferhoyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josunect josunect merged commit c0cb2d4 into kiali:staging Jan 31, 2025
5 checks passed
@josunect josunect deleted the ambient-tracing branch January 31, 2025 13:11
@jmazzitelli
Copy link
Contributor

I'm late to the party here but @josunect didn't you ask if upstream Istio can add the workload name to the trace data for better correlation? If so, and if there is an upstream Istio github issue, I would mention that issue in the docs.. something like:

As the workload name is not part of the trace information, there are some gaps in the trace overlay.
(These gaps will hopefully be fixed in upstream Istio in a future Istio release - see GitHub issue XXX for
details on that enhancement request.)

@josunect
Copy link
Contributor Author

I'm late to the party here but @josunect didn't you ask if upstream Istio can add the workload name to the trace data for better correlation? If so, and if there is an upstream Istio github issue, I would mention that issue in the docs.. something like:

As the workload name is not part of the trace information, there are some gaps in the trace overlay.
(These gaps will hopefully be fixed in upstream Istio in a future Istio release - see GitHub issue XXX for
details on that enhancement request.)

Right, that's correct, @jmazzitelli . Shouldn't we link a Kiali issue better that is linked to that Istio issue? Because even if that is fixed, Kiali code will still need some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

3 participants