- 
                Notifications
    
You must be signed in to change notification settings  - Fork 70
 
Add Ambient tracing section #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Josune for extending Ambient docs! I have added some optional suggestions and found a small typo at the end.
Co-authored-by: Fernando Hoyos <[email protected]>
Co-authored-by: Fernando Hoyos <[email protected]>
Co-authored-by: Fernando Hoyos <[email protected]>
Co-authored-by: Fernando Hoyos <[email protected]>
          
 thanks for the review!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 
           I'm late to the party here but @josunect didn't you ask if upstream Istio can add the workload name to the trace data for better correlation? If so, and if there is an upstream Istio github issue, I would mention that issue in the docs.. something like:  | 
    
          
 Right, that's correct, @jmazzitelli . Shouldn't we link a Kiali issue better that is linked to that Istio issue? Because even if that is fixed, Kiali code will still need some changes.  | 
    
https://deploy-preview-856--kiali.netlify.app/docs/features/ambient/#ambient-tracing