KEYCLOAK-18842: convert subquery to join #8280
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prevent bad performance on databases that cannot optimize subqueries in deletes, transformed the deleteExpiredClientSessions statement. Also had to use SQL because JPA does not allow joins in deletes.
Contributor
|
Thank you for the PR. Sadly, the native SQL is not compatible with other database engines. This issue is valid, and needs to be fixed by some other solution, ideally overriding the |
Contributor
|
Replaced by #8415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent bad performance on databases that cannot
optimize subqueries in deletes, transformed the deleteExpiredClientSessions
statement.
Also had to use SQL because JPA does not allow joins in deletes.