KEYCLOAK-15459 Fix serialization of multi-subtag locales in admin console's “whoami” response #7397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devopsix
commented
Sep 6, 2020
- Serialize locale as a well-formed IETF BCP 47 language tag.
- Alter test to cover a locale made of more than one subtag.
rushairer
reviewed
Feb 1, 2021
rushairer
left a comment
There was a problem hiding this comment.
When can I merge this code and fix the bug?
Contributor
|
@abstractj I am unable to restart tests to get them passing. Are you able to do this? |
Contributor
|
@ssilvert let me give it a try |
ssilvert
approved these changes
Mar 29, 2021
SergiusAC
pushed a commit
to SergiusAC/keycloak
that referenced
this pull request
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.