Skip to content

fix: correcting termination test on openshift (#44181) #44297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shawkins wants to merge 1 commit into
base: release/26.4
Choose a base branch
from
Open

fix: correcting termination test on openshift (#44181) #44297

shawkins wants to merge 1 commit into from

Conversation

@shawkins
Copy link
Contributor

@shawkins shawkins commented Nov 18, 2025

closes: #44179

(cherry picked from commit f96765c)

@shawkins shawkins requested review from a team as code owners November 18, 2025 16:15
@shawkins shawkins force-pushed the backport-44181-26.4 branch from 118de12 to 6af9fb3 Compare November 18, 2025 18:40
@shawkins shawkins requested a review from vmuzikar November 18, 2025 18:40
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Nov 18, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Nov 18, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPProvidersIntegrationTest#updateLDAPUsernameTest

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.junit.Assert.assertNotNull(Assert.java:723)
...

Report flaky test

@shawkins
fix: correcting termination test on openshift (keycloak#44181)
090fd68 
closes: keycloak#44179

Signed-off-by: Steve Hawkins <[email protected]>
(cherry picked from commit f96765c)
@shawkins shawkins force-pushed the backport-44181-26.4 branch from 6af9fb3 to 090fd68 Compare November 19, 2025 15:38
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Nov 19, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Nov 19, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPProvidersIntegrationTest#updateLDAPUsernameTest

Keycloak CI - Base IT (5)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.junit.Assert.assertNotNull(Assert.java:723)
...

Report flaky test

@shawkins shawkins requested review from Pepo48 and mabartos November 19, 2025 19:20
@vmuzikar vmuzikar enabled auto-merge (squash) November 20, 2025 13:19
@vmuzikar vmuzikar disabled auto-merge December 2, 2025 14:32
@vmuzikar vmuzikar enabled auto-merge (squash) December 2, 2025 14:32
@vmuzikar vmuzikar disabled auto-merge December 16, 2025 14:21
@vmuzikar vmuzikar enabled auto-merge (squash) December 16, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pepo48 Pepo48 Pepo48 approved these changes

@vmuzikar vmuzikar vmuzikar approved these changes

@mabartos mabartos Awaiting requested review from mabartos

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawkins @Pepo48 @vmuzikar