Sessions not removed when user is deleted #44091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes keycloak#43323 Signed-off-by: Pedro Ruivo <[email protected]>
Signed-off-by: Pedro Ruivo <[email protected]>
ahus1
approved these changes
Nov 11, 2025
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Thank you for this fix! I don't think there is a need to backport this to 26.4 - please let me know if you think otherwise.
If we would choose to backport it, it would be good to first backport the new classes ClientSessionFilterByUser and RemoveKeyConsumer in one patch release, and the other changes in another patch release.
I assume that this would only be triggered when a user is deleted which is rare, this would be the extra mile I would like to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43323