Skip to content

Add name uniqueness validation to workflows #44999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 1 commit into from
Dec 29, 2025
Merged

Add name uniqueness validation to workflows #44999

pedroigor merged 1 commit into from
Dec 29, 2025
+58 −34

Conversation

@sguilhen
Copy link
Contributor

@sguilhen sguilhen commented Dec 18, 2025

Closes #43914

@sguilhen sguilhen requested a review from a team as a code owner December 18, 2025 13:31
@sguilhen sguilhen requested review from ssilvert and vramik December 18, 2025 13:31
ssilvert
ssilvert previously approved these changes Dec 18, 2025
View reviewed changes
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Dec 18, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Dec 18, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.AuthenticatorSubflowsTest2#testSubflow2

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected AppPage but was PushTheButton (https://localhost:8543/auth/realms/test/login-actions/authenticate?execution=638122f8-965f-4575-bcb3-7920e9b2d738&client_id=test-app&tab_id=9nGuhn_0Hzo&client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIn0)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:39)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@sguilhen sguilhen force-pushed the 43914-workflows-validation branch from 5115737 to 2c76f54 Compare December 19, 2025 14:56
@sguilhen sguilhen force-pushed the 43914-workflows-validation branch 2 times, most recently from badc2a2 to 4089222 Compare December 19, 2025 18:30
@sguilhen
Add name uniqueness validation to workflows
ce570d1 
Closes keycloak#43914

Signed-off-by: Stefan Guilhen <[email protected]>

# Conflicts:
#	tests/base/src/test/java/org/keycloak/tests/workflow/WorkflowManagementTest.java
@sguilhen sguilhen force-pushed the 43914-workflows-validation branch from 4089222 to ce570d1 Compare December 23, 2025 17:51
@pedroigor pedroigor merged commit 985ec6d into keycloak:main Dec 29, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

@ssilvert ssilvert ssilvert left review comments

@vramik vramik Awaiting requested review from vramik

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance workflows validation

3 participants

@sguilhen @ssilvert @pedroigor