Validate client session timeout and lifetime settings on realm settings edit #44968
+92
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98dae2c to
822ebae
Compare
ryanemerson
requested changes
Dec 18, 2025
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
tests/base/src/test/java/org/keycloak/tests/admin/realm/RealmUpdateTest.java
Show resolved
Hide resolved
c7e8bd2 to
ed82725
Compare
ryanemerson
requested changes
Dec 18, 2025
Contributor
ryanemerson
left a comment
There was a problem hiding this comment.
I have pushed a couple of commits to simplify things, please see the commit message for an explanation.
We also still need to update docs/documentation/upgrading/topics/changes/changes-26_5_0.adoc to reflect that we now validate the client settings.
...storage-private/src/main/java/org/keycloak/storage/datastore/DefaultExportImportManager.java
Outdated
Show resolved
Hide resolved
e0bc865 to
e9e934c
Compare
ryanemerson
previously approved these changes
Dec 19, 2025
Closes keycloak#44910 Signed-off-by: Ruchika <[email protected]> Signed-off-by: Ryan Emerson <[email protected]> Co-authored-by: Ryan Emerson <[email protected]>
e9e934c to
87da3db
Compare
Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
approved these changes
Jan 5, 2026
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Thank you for the change! I've updated the migration guide a bit to also include the realm settings that are now validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate client session timeout and lifetime settings on realm settings edit and testcase for the same.
Closes #44910