Skip to content

Make pending email verification attribute removable by admin #43354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 2 commits into from
Oct 20, 2025
Merged

Make pending email verification attribute removable by admin #43354

pedroigor merged 2 commits into from
Oct 20, 2025

Conversation

@martin-kanis
Copy link
Contributor

@martin-kanis martin-kanis commented Oct 10, 2025

Closes #43351

@martin-kanis martin-kanis requested review from a team as code owners October 10, 2025 10:19
@martin-kanis martin-kanis force-pushed the 43351 branch 2 times, most recently from ccdb14c to ab95be8 Compare October 10, 2025 11:30
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Oct 10, 2025
Closed
@pedroigor pedroigor requested a review from ssilvert October 13, 2025 12:10
ssilvert
ssilvert requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@ssilvert ssilvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-kanis This is only meant for the admin UI, right?

the ui-shared library is meant for code that is common to both admin console and account console. So I'm a little hesitant to add all this code to the library. Can you think of a way to do this were the code that only applies to admin console stays in the admin-ui code base?

@pedroigor
Copy link
Contributor

pedroigor commented Oct 14, 2025

the ui-shared library is meant for code that is common to both admin console and account console. So I'm a little hesitant to add all this code to the library. Can you think of a way to do this were the code that only applies to admin console stays in the admin-ui code base?

The first option was to just allow the admin to clear the value (deleting text) and then click Save. The goal here is to allow the admin to clear this field so that the attribute holding the email pending for confirmation is removed.

@martin-kanis martin-kanis force-pushed the 43351 branch 2 times, most recently from 0001778 to 690463a Compare October 15, 2025 16:22
pedroigor
pedroigor previously approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @martin-kanis !

@pedroigor pedroigor requested a review from ssilvert October 16, 2025 10:12
@pedroigor pedroigor enabled auto-merge (rebase) October 16, 2025 10:12
ssilvert
ssilvert requested changes Oct 16, 2025
View reviewed changes
js/apps/admin-ui/src/user/UserForm.tsx Outdated
isPlain
title={t("emailPendingVerificationAlertTitle")}
>
The user has not confirmed the new email address{" "}
Copy link
Contributor

@ssilvert ssilvert Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be localized.

Copy link
Contributor

@pedroigor pedroigor Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. I did not find a way to bold the email in the message property. Is it possible to do that?

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 17, 2025
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 17, 2025

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.account.AccountRestServiceTest#listApplicationsWithoutPermission

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

org.openqa.selenium.TimeoutException: 
java.net.SocketTimeoutException: Read timed out
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Windows Server 2025', os.arch: 'amd64', os.version: '10.0', java.version: '17.0.16'
Driver info: driver.version: HtmlUnitDriver
...

Report flaky test

@pedroigor pedroigor merged commit c4edb97 into keycloak:main Oct 20, 2025
79 checks passed
@martin-kanis martin-kanis mentioned this pull request Nov 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes

@pedroigor pedroigor pedroigor approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make pending email verification attribute removable by admin

3 participants

@martin-kanis @pedroigor @ssilvert