Disable Secure Client-Initiated Renegotiation by default #43092
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter -Djdk.tls.rejectClientInitiatedRenegotiation=true disables Secure Client-Initiated Renegotiation in Keycloak to resolve a potential DoS vulnerability. Note this is applicable only to TLS 1.2. Signed-off-by: Erasure5959 <[email protected]>
The parameter -Djdk.tls.rejectClientInitiatedRenegotiation=true disables Secure Client-Initiated Renegotiation in Keycloak to resolve a potential DoS vulnerability. Note this is applicable only to TLS 1.2. Signed-off-by: Erasure5959 <[email protected]>
Signed-off-by: Alexander Schwartz <[email protected]>
ahus1
approved these changes
Oct 1, 2025
Contributor
ahus1
left a comment
There was a problem hiding this comment.
Thank you for contributing this change! I see one of our tests failed, and I had to remove a blank from one of the scripts.
Contributor
Author
|
Thank you for being open to the change and allowing me to contribute - apologies for my oversight. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43020
This PR aims to disable Secure Client-Initiated Renegotiation by default in Keycloak. The current configuration represents a potential attack vector via DoS; closing this avenue by default is desirable and should have no adverse side effects.
This is applicable to TLS 1.2 only; TLS 1.3 completely removes support for renegotiation.