Skip to content

feat(token-manager): make OIDC and models TokenManagers pluggable via… #43053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sashyo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(token-manager): make OIDC and models TokenManagers pluggable via… #43053

sashyo wants to merge 1 commit into from

Conversation

@sashyo
Copy link
Contributor

@sashyo sashyo commented Sep 30, 2025

Relates to #43052

This PR introduces SPIs for both the models TokenManager and the OIDC TokenManager to make them pluggable.

  • Models (server-spi): TokenManager now a Provider with TokenManagerFactory and TokenManagerSpi. Default factory returns the stock implementation.
  • OIDC (services): New TokenManagerProvider, TokenManagerProviderFactory, and DefaultTokenManagerProviderFactory. Resolution is centralized via TokenManager.resolve(session, logger).
  • Fallback: If a provider is configured and loadable, Keycloak uses it. Otherwise, the default managers are used (backward compatible).

This enables deployments to supply custom token pipelines with:

--spi-token-manager-provider=<id>
--spi-oidc-token-manager-provider=<id>

@sashyo sashyo requested a review from a team as a code owner September 30, 2025 06:51
@sashyo
feat(token-manager): make OIDC and models TokenManagers pluggable via…
32ad0e7 
… SPIs

move resolveOIDCTokenManager to central spot

fix

Signed-off-by: Sasha Le <[email protected]>
@sashyo sashyo force-pushed the feature/tokenmanager-spis branch from 911447b to 32ad0e7 Compare September 30, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor Awaiting requested review from pedroigor

@stianst stianst Awaiting requested review from stianst

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sashyo