Don't keep an old session to avoid a stable object and a memory leak #43762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ryanemerson - please review when have the time and feel familiar enough with the code at hand. Thanks! |
ryanemerson
reviewed
Oct 28, 2025
services/src/main/java/org/keycloak/timer/basic/BasicTimerProvider.java
Outdated
Show resolved
Hide resolved
Contributor
|
@ahus1 I pushed a commit to reduce repetition, feel free to disregard if you prefer the more verbose code. |
ryanemerson
previously approved these changes
Oct 28, 2025
Closes keycloak#43761 Signed-off-by: Alexander Schwartz <[email protected]>
b05c8d1 to
480f4c8
Compare
Contributor
Author
|
@ryanemerson or @shawkins - please re-review when you have the time. Thanks! |
ryanemerson
approved these changes
Oct 29, 2025
pedroigor
approved these changes
Oct 29, 2025
shawkins
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43761